Two bugs in r1624

The first one is still there, the second one is fixed AFAIK.

Found another bug: nullable type in Tuple causes error report even though this error is not possible.

http://img168.imageshack.us/img168/1900/66904074.jpg

There's at least one bug in XML auto formatting. If I'm editting some XAML file:

        <Style x:Key="ItemtViewStyle" TargetType="TabItem">
            <Setter Property="Header" Value="{Binding Name}"/>
            <Setter Property="Content" Value="{Binding}"/>
        </Style>
and hit enter when cursor is near the TargetType, no matter what settings is active the argument is aligned to the first argument in the same tag. I want the argument to align 'One indent', but it does not work. It actually work only when the entire block is selected and I hit the auto format shortcut.

Another bug, this occured to me todat after addin one method argument before the string one.
http://img35.imageshack.us/img35/6932/23945858.jpg

another problem, not sure if it's a bug or I don't know how to set it in settings:
in property initialization I want the braces autoformatted this way:

var x = new ContainerWorkspaceItem

{

    PanelName = Name,

    Parent = ParentView.ToString(),

    Children = Children.Select(i => i.GetWorkspaceItem()).ToList()

};

not this way:

var x = new ContainerWorkspaceItem

        {

            PanelName = Name,

            Parent = ParentView.ToString(),

            Children = Children.Select(i => i.GetWorkspaceItem()).ToList()

        };

ReSharper->Options->Formatting Style->Other->Indent array, object and collection initializer

Thanks, that helped with the braces.

But now I am wondering about this: I got in my class call:

bool b = MyStruct.Equals(item1, item2);
MyStruct implements IEquatable<T>

ReSharper is suggesting replacing MyStruct with object and then ommiting object at all. I guess that's not right solution, because using just Equals(item1, item2); gets different result than MyStruct.Equals(item1, item2);
There shouldn't be suggested replacement from MyStuct.Equals to object.Equals at all.

edit... it looks like a problem in my code, there's no implementation of Equals with two parameters in MyStruct...

Could you provide full piece of code, please?

As far as I understand you invoke static method from Object class Object.Equals(object, object) and you haven't method with such signature in your structure 'MyStruct' that's why you have this warning.

I've found out, that it's not a problem in ReSharper at all. We got custom Equals(x) implementation which i used by te default Object.Equals(x, y) method.

But another idea for refacotring operation: there's no hint for removing redundant return; calls for example at the end of a method.
void DoStuff()
{
    // something

    return; // should be labeled as safe to remove
}