Feature request: support C#8 nullable types as it was declared in R# marketing materials

Here are a bunch of bugs: https://github.com/astef/ReSharperBugs

Two the most important of them are:

  • invalid R# error: "Left operand of the '??' operator should be of reference or nullable type"
  • invalid R# error and invalid refactoring: "The class type constraint 'Item' must come before any other constraints"

Can you please review them and increase the priority of these?

10 comments
Comment actions Permalink
Official comment

Hello Alexander,

 

Thank you for the provided info. My respects for your detailed and illustrative bug report.

Some of the issues (compiler warnings support) were reported, some of them I've filed:

Invalid error: "Left operand of the '??' operator should be of reference or nullable type" - https://youtrack.jetbrains.com/issue/RSRP-477052

Invalid error "The class type constraint 'Item' must come before any other constraints" - https://youtrack.jetbrains.com/issue/RSRP-477054

CS8602 support - https://youtrack.jetbrains.com/issue/RSRP-473949

CS8603 support - https://youtrack.jetbrains.com/issue/RSRP-475345

CS8600 support - https://youtrack.jetbrains.com/issue/RSRP-473949

Incorrect "Make class abstract" suggestion - https://youtrack.jetbrains.com/issue/RSRP-477060

To those that you've marked as most important, we've set Show-Stopper priority.

Please let me know if you have any more questions.

Thank you.

Comment actions Permalink

Hello Angelina,

When can we expect this to be fixed? Some of the bugs/features has been reported for 5-8 month now. 

0
Comment actions Permalink

Hello Daniel,

Fix for RSRP-477052 and RSRP-477054 will be included in the upcoming ReSharper 2019.3 release, even in ReSharper 2019.3 EAP6 build that will be published next week.

The other issues will be fixed in future versions.

Thank you.

 

 

0
Comment actions Permalink

Hello Angelina,

All issues, including RSRP-477054 and RSRP-477052 has been reproduced by me with ReSharper 2019.3 EAP6.

Is it possible to double check that those tickets will not be missed in future EAPs?

 

Thank you.

0
Comment actions Permalink

Hello Alexander,

 

We’ve published the ReSharper Ultimate 2019.3 EAP6 build, but it had no fixes. Because of our pipeline and the deployment process, when we fixed an issue in Rider and published a new Rider build, we had to build and publish a new ReSharper build as well. So the specified fixes will come in EAP7 build. 

Please accept our apologies for inconvenience.

Thank you.

0
Comment actions Permalink

This still isn't fixed with the newly released 2019.3.

Are there any plans to fix this as a hotfix because it is extremely annoying.

1
Comment actions Permalink

Hello David,

 

Could you please specify what problems are not fixed in 2019.3. 

RSRP-477052 and RSRP-477054 were planned in 2019.3 release and as far as I see they are actually fixed.

Thank you.

0
Comment actions Permalink

Hi Angelina,

https://youtrack.jetbrains.com/issue/RIDER-33600 was forwarded to https://youtrack.jetbrains.com/issue/RSRP-475345 which then linked this support post.  But both of those issues are still outstanding.

I can see the error CS8618 the build window, but there is no feedback in the editor or solution wide analysis.

The following diagnostics do not show in the editor or solution wide analysis (that I have noticed)

* CS8618
* CS8614
* CS8620
* CS8619

 

1
Comment actions Permalink

Hello David,

 

We are planning to add support of those warnings in ReSharper 2020.1.

Please follow https://youtrack.jetbrains.com/issue/RSRP-475345 to get the latest updates.

Thank you.

0
Comment actions Permalink

The following diagnostics are also not being detected by ReSharper 2019.3:

  • CS8600
  • CS8625
1

Please sign in to leave a comment.