Resharper sucks

#region Menu Items
private void newToolStripMenuItem_Click(object sender, EventArgs e)
{
     if (m_Project != null)
     {
          closeToolStripMenuItem_Click(null, EventArgs.Empty);

          if (m_Project != null)
               return; // Project is still open; closing the old one must have failed
     }



Resharper thinks that the second if is redundant ("Expression is always true").

Bullshit.

closeToolStripMenuItem_Click alone will decide what the value of  m_Project will be when it completes. Therefore, the expression is not always true.

I really hate software that thinks it's smarter than I am.

The only thing Resharper does well is refactor. Everything else should be a separate product. The Visual Studio integration is so intrusive that if I turn code analysis off completely (most of the hints are counter-productive and annoying), VS' own code analysis doesn't work anymore either.

1 comment
Comment actions Permalink

Hello,

Thank you very much for feedback! This is a known problem as ReSharper doesn't
yet perform an interprocedural value-flow analysis on-the-fly and doesn't
know that the value of m_Project can change inside tripMenuItem_Click. We're
planning to address this problem in one of the future releases. As to VS'
own code analysis, you can enable it back by turning on 'Underline errors
in the editor' option under Tools | Options | Text Editor | C# | Advanced.

Andrey Serebryansky
Support Engineer
JetBrains, Inc
http://www.jetbrains.com
"Develop with pleasure!"

#region Menu Items

private void newToolStripMenuItem_Click(object sender, EventArgs e)

{

     if (m_Project != null)

     {

          closeToolS
tripMenuItem_Click(null, EventArgs.Empty);

          if
(m_Project != null)

           &nbs
p;   return; // Project is still open; closing the old
one must have failed

     }

Resharper thinks that the second if is redundant ("Expression is
always true").

Bullshit.

newToolStripMenuItem_Click alone will decide what the value of
m_Project will be when it completes. Therefore, the expression is
not always true.

I really hate software that thinks it's smarter than I am.

The only thing Resharper does well is refactor. Everything else should
be a separate product. The Visual Studio integration is so intrusive
that if I turn code analysis off completely (most of the hints are
counter-productive and annoying), VS' own code analysis doesn't work
anymore either.

---
Original message URL:
http://devnet.jetbrains.net/message/5268592#5268592



0

Please sign in to leave a comment.