Open for discussion: #3248- Inline rename should prevent user from entering charaters that are not allowed in identifiers

State of request #3248- Inline rename should prevent user from entering charaters that are not allowed in identifiers
has changed to "To be discussed". If you want to comment on it please do not reply to this message but add comment to the request's thread instead at http://www.intellij.net/tracker/resharper/viewSCR?publicId=3248

4 comments
Comment actions Permalink

Personally, I think there should be no such thing as inline rename :) I don't see any value in it. Dialog with name check (also for conflicts) would be fine for me.

0
Comment actions Permalink

However, inline rename is generally much faster because it does not require
showing a dialog, pressing OK etc. In other words,
you can apply inline rename without distracting from code editing.

"Ilya Ryzhenkov" <no_mail@jetbrains.com> wrote in message
news:18254335.1088169414942.JavaMail.itn@is.intellij.net...

Personally, I think there should be no such thing as inline rename :) I

don't see any value in it. Dialog with name check (also for conflicts) would
be fine for me.


0
Comment actions Permalink

Hmm, what is the difference? I goto entity I need to rename, hit key combo and: (1) for inline (2) for dialog

(1) entity is outlined with red mark or (2) dialog is displayed

(1) type new name (slow, because it changes all the code) (2) type new name

(1) hit enter (2) hit enter (if there is no error detected for identifier)

So from the actions point of view, dialog is better. The only thing which is better about inline rename, is that you don't move your eyes around the screen.

PS: Again, I'd like to point KISS principle - don't force users to learn so many concepts. Stick with simple stupid. IMHO, of course.

0
Comment actions Permalink

These actions are phycologically diffferent. Many users do not like modal
dialogs hanging over the code, especially sequences of them (one with the
name, another with conflicts and so on).
I prefer the inline rename. I would be happy if, when I type something
invalid the code, the rename red frame would change its color, or blink, or
signal about the conflict/invalid input in some other way.

--
Andrey Simanovsky
Software Developer
JetBrains, Inc
http://www.jetbrains.com
"Develop with pleasure!"



"Ilya Ryzhenkov" <no_mail@jetbrains.com> wrote in message
news:16795558.1088170234415.JavaMail.itn@is.intellij.net...

Hmm, what is the difference? I goto entity I need to rename, hit key combo

and: (1) for inline (2) for dialog
>

(1) entity is outlined with red mark or (2) dialog is displayed

>

(1) type new name (slow, because it changes all the code) (2) type new

name
>

(1) hit enter (2) hit enter (if there is no error detected for identifier)

>

So from the actions point of view, dialog is better. The only thing which

is better about inline rename, is that you don't move your eyes around the
screen.
>

PS: Again, I'd like to point KISS principle - don't force users to learn

so many concepts. Stick with simple stupid. IMHO, of course.
>


0

Please sign in to leave a comment.