Action list light bulbs getting on my nerves

Hi all

Just a little thing that has been bugging me for a while now. In the new resharper it seems that the action list light bulbs come up a lot more than in the old (1.5) version. Now in some cases that is good and I'm really happy with them but there are times when they annoy me.

For instance one of my settings is that resharper should always add braces to if statements. The problem is that the light bulb pops up when I have an if statement with one line in the then part and the suggestion is to remove the braces. That seems rather self defeating because on the next format they will come back.
Another one is that I set the warnings for the doc comments to indicate as error (because of my compiler settings). And then if I work on a doc comment and have an error the light bulb pops up asking if I want to turn that setting off. Well no thank you.

My main point is probably that I gotten to expect really useful things from the light bulb and not it second guessing my own settings. Also things like splitting declaration and initialization of a variable (try writing int i = 10;) is not very useful and it's fairly easy to do myself. So is there a way to return the usefulness of the light bulb by turning off all the annoying messages? Or maybe the jetbrains guys can make the messages more consistent with the settings (even if that is for a next version of Resharper).

Anyway thanks for listing to me rant.

Petrik

9 comments
Comment actions Permalink

I like the light bulbs, you can manipulate settings at the most logical
place: the place you need them and would want to set them quickly
without having to dig into settings dialogs...

Patrick wrote:

Hi all

Just a little thing that has been bugging me for a while now. In the new resharper it seems that the action list light bulbs come up a lot more than in the old (1.5) version. Now in some cases that is good and I'm really happy with them but there are times when they annoy me.

For instance one of my settings is that resharper should always add braces to if statements. The problem is that the light bulb pops up when I have an if statement with one line in the then part and the suggestion is to remove the braces. That seems rather self defeating because on the next format they will come back.
Another one is that I set the warnings for the doc comments to indicate as error (because of my compiler settings). And then if I work on a doc comment and have an error the light bulb pops up asking if I want to turn that setting off. Well no thank you.

My main point is probably that I gotten to expect really useful things from the light bulb and not it second guessing my own settings. Also things like splitting declaration and initialization of a variable (try writing int i = 10;) is not very useful and it's fairly easy to do myself. So is there a way to return the usefulness of the light bulb by turning off all the annoying messages? Or maybe the jetbrains guys can make the messages more consistent with the settings (even if that is for a next version of Resharper).

Anyway thanks for listing to me rant.

Petrik

0
Comment actions Permalink

Hello Patrick,

I also would like to exclude "Disable warning" quickfixes from the list.
Not only I find it useless, but sometimes it accidentaly gets triggered.
For example, I position caret on the place where I expect specific quickfix
(like, it always been there) and right after lightbulb appears I hit alt-enter,
enter to apply it. Unfortunately, QF can be not available due to some reason
and what gets triggered is that "disable warning" command. But I still think
that QF I expected was executed, because warning marker disappeared! Then
I'm looking at the code that should have been changed, and I see no change!
I have some time to understand, that I just disabled warning, go to options,
enable it, find it again and check what happens again.

In short: Give option to disable this QF.

Sincerely,
Ilya Ryzhenkov


P> Hi all
P>
P> Just a little thing that has been bugging me for a while now. In the
P> new resharper it seems that the action list light bulbs come up a lot
P> more than in the old (1.5) version. Now in some cases that is good
P> and I'm really happy with them but there are times when they annoy
P> me.
P>
P> For instance one of my settings is that resharper should always add
P> braces to if statements. The problem is that the light bulb pops up
P> when I have an if statement with one line in the then part and the
P> suggestion is to remove the braces. That seems rather self defeating
P> because on the next format they will come back.
P>
P> Another one is that I set the warnings for the doc comments to
P> indicate as error (because of my compiler settings). And then if I
P> work on a doc comment and have an error the light bulb pops up asking
P> if I want to turn that setting off. Well no thank you.
P>
P> My main point is probably that I gotten to expect really useful
P> things from the light bulb and not it second guessing my own
P> settings. Also things like splitting declaration and initialization
P> of a variable (try writing int i = 10;) is not very useful and it's
P> fairly easy to do myself. So is there a way to return the usefulness
P> of the light bulb by turning off all the annoying messages? Or maybe
P> the jetbrains guys can make the messages more consistent with the
P> settings (even if that is for a next version of Resharper).
P>
P> Anyway thanks for listing to me rant.
P>
P> Petrik
P>


0
Comment actions Permalink

Hi all,

We have opened an SCR: http://www.intellij.net/tracker/resharper/viewSCR?publicId=25304
It won't make it to 2.0 though, I am afraid...

Friendly,
Dmitry

Hi all

Just a little thing that has been bugging me for a while now. In the
new resharper it seems that the action list light bulbs come up a lot
more than in the old (1.5) version. Now in some cases that is good and
I'm really happy with them but there are times when they annoy me.

For instance one of my settings is that resharper should always add
braces to if statements. The problem is that the light bulb pops up
when I have an if statement with one line in the then part and the
suggestion is to remove the braces. That seems rather self defeating
because on the next format they will come back.

Another one is that I set the warnings for the doc comments to
indicate as error (because of my compiler settings). And then if I
work on a doc comment and have an error the light bulb pops up asking
if I want to turn that setting off. Well no thank you.

My main point is probably that I gotten to expect really useful things
from the light bulb and not it second guessing my own settings. Also
things like splitting declaration and initialization of a variable
(try writing int i = 10;) is not very useful and it's fairly easy to
do myself. So is there a way to return the usefulness of the light
bulb by turning off all the annoying messages? Or maybe the jetbrains
guys can make the messages more consistent with the settings (even if
that is for a next version of Resharper).

Anyway thanks for listing to me rant.

Petrik

--
Dmitry Lomov
Senior Software Developer
JetBrains, Inc.
"Develop With Pleasure!"


0
Comment actions Permalink

Hi Wiebe

I probably don't explained myself correctly, I love the light bulbs. What I don't like is that in the new version of Resharper they tend to pop up in places where they are more annoying than useful. I've been trained to look for the light bulbs and if they appear it usually means there is an error that can be fixed with the light bulb actions. However in the new build there are tons of 'fixes' that aren't actually fixes. For instance if you put the cursor on the visibility keywords (public, internal, protected, private) then you get a light bulb that suggests changing the visibility. Not really useful in my opinion.

In short my whole rant was more a request to remove some of the suggestions so that the light bulbs are more effective.

Patrick

I like the light bulbs, you can manipulate settings
at the most logical
place: the place you need them and would want to set
them quickly
without having to dig into settings dialogs...

>

0
Comment actions Permalink

Hi Dmitry

Thanks for that. I realized that it wouldn't make 2.0 but at least you are now aware of my 'issue' ;)

Thanks for your help

Patrick

Hi all,

We have opened an SCR:
http://www.intellij.net/tracker/resharper/viewSCR?publ
icId=25304
It won't make it to 2.0 though, I am afraid...

Friendly,
Dmitry

0
Comment actions Permalink

You may notice a difference in the lightbulb appearance between a fix for
an error/warning and a "context action" bulb, do you?

Valentin Kipiatkov
Chief Scientist, Vice President of Product Development
JetBrains, Inc
http://www.jetbrains.com
"Develop with pleasure!"

Hi Wiebe

I probably don't explained myself correctly, I love the light bulbs.
What I don't like is that in the new version of Resharper they tend to
pop up in places where they are more annoying than useful. I've been
trained to look for the light bulbs and if they appear it usually
means there is an error that can be fixed with the light bulb actions.
However in the new build there are tons of 'fixes' that aren't
actually fixes. For instance if you put the cursor on the visibility
keywords (public, internal, protected, private) then you get a light
bulb that suggests changing the visibility. Not really useful in my
opinion.

In short my whole rant was more a request to remove some of the
suggestions so that the light bulbs are more effective.

Patrick

>> I like the light bulbs, you can manipulate settings
>> at the most logical
>> place: the place you need them and would want to set
>> them quickly
>> without having to dig into settings dialogs...


0
Comment actions Permalink

Valentin,
This is exactly what I was talking some time before. There are number of
context actions a person might not want to see at all (i.e. braces in if's
and loops if he/she always uses braces). I think, we should make an option
to disable context actions.

--
Sergey V. Coox
JetBrains, Inc
http://www.jetbrains.com
"Develop with pleasure!"


0
Comment actions Permalink

Hello Sergey,

I'm second for that. I personally will never use context action for removing
braces and the like.


Regards,
Dmitry Shaporenkov
JetBrains, Inc
http://www.jetbrains.com
"Develop with pleasure!"

Valentin,
This is exactly what I was talking some time before. There are number
of
context actions a person might not want to see at all (i.e. braces in
if's
and loops if he/she always uses braces). I think, we should make an
option
to disable context actions.



0
Comment actions Permalink

Hi All,

Tracker to the rescue!
http://www.intellij.net/tracker/resharper/viewSCR?publicId=25304

Cheers,
Dmitry

Hello Sergey,

I'm second for that. I personally will never use context action for
removing braces and the like.

Regards,
Dmitry Shaporenkov
JetBrains, Inc
http://www.jetbrains.com
"Develop with pleasure!"

>> Valentin,
>> This is exactly what I was talking some time before. There are number
>> of
>> context actions a person might not want to see at all (i.e. braces in
>> if's
>> and loops if he/she always uses braces). I think, we should make an
>> option
>> to disable context actions.
--
Dmitry Lomov
Senior Software Developer
JetBrains, Inc.
"Develop With Pleasure!"


0

Please sign in to leave a comment.