[774] Reentrancy bug!!

Hello Stefan,

We are doing major refactoring in the field of multithreading and reentrancy
policy (when message loop pumps messages in an unexpected time, e.g. lock)
and few nightly builds could be broken. Unfortunately, this cannot be done
in "atomic" manner, so that nightly builds remain stable, sorry for inconvenience.

Sincerely,
Ilya Ryzhenkov

JetBrains, Inc
http://www.jetbrains.com
"Develop with pleasure!"


SL> Hi,
SL>
SL> I just tried build 774, its unusable! I'm bombed with exceptions
SL> about reentrancy. Btw. the logs of the last builds have huge amounts
SL> of messages regarding reentrancy. Example from 774 below. Switching
SL> back to 772.
SL>
SL> Regards,
SL> Stefan Lieser
SL> 12:42:57.493: Thread:1: EXCEPTION: The time interval must refer to a
SL> moment in the future.
SL> Parameter name: interval
SL> Actual value was 00:00:00.
SL> JetBrains.Util.LoggerException: The time interval must refer to a
SL> moment
SL> in the future.
SL> Parameter name: interval
SL> Actual value was 00:00:00. ---> System.ArgumentOutOfRangeException:
SL> The
SL> time interval must refer to a moment in the future.
SL> Parameter name: interval
SL> Actual value was 00:00:00.
SL> at JetBrains.Threading.ReentrancyAlarm.TimedAction..ctor(String
SL> name, Action action, TimeSpan interval, Recurrence recurrence,
SL> ReentrancyGuard reega) in
SL> c:\Agent\work\2722e5c3778024b1\Platform\src\Util\src\Concurrency\Ree
SL> ntrancyAlarm.cs:line
SL> 342
SL> at JetBrains.Threading.ReentrancyAlarm.QueueTimed(String name,
SL> Action action, TimeSpan interval, Recurrence recurrence) in
SL> c:\Agent\work\2722e5c3778024b1\Platform\src\Util\src\Concurrency\Ree
SL> ntrancyAlarm.cs:line
SL> 163
SL> at JetBrains.Threading.ReentrancyAlarm.QueueAt(String name,
SL> Action
SL> action, TimeSpan interval) in
SL> c:\Agent\work\2722e5c3778024b1\Platform\src\Util\src\Concurrency\Ree
SL> ntrancyAlarm.cs:line
SL> 130
SL> at JetBrains.Threading.Invocator.QueueAt(String name, Action
SL> action,
SL> TimeSpan interval) in
SL> c:\Agent\work\2722e5c3778024b1\Platform\src\Shell\src\Threading\Invo
SL> cator.cs:line
SL> 85
SL> at
SL> JetBrains.ReSharper.CodeInsight.Services.ParameterInfo.ParameterInfo
SL> PopupControllerImpl.PopupParameterInfo(ILookup
SL> lookup, ISolution solution) in
SL> c:\Agent\work\2722e5c3778024b1\src\CodeInsight.Services\src\Paramete
SL> rInfo\ParameterInfoPopupControllerImpl.cs:line
SL> 107
SL> at
SL> JetBrains.ReSharper.CodeInsight.Services.ParameterInfo.LookupSummary
SL> Tracker.ShowParameterInfo(ILookup
SL> lookup) in
SL> c:\Agent\work\2722e5c3778024b1\src\CodeInsight.Services\src\Paramete
SL> rInfo\LookupSummaryTracker.cs:line
SL> 132
SL> at
SL> JetBrains.ReSharper.CodeInsight.Services.ParameterInfo.LookupSummary
SL> Tracker.b__0() SL> in SL> c:\Agent\work\2722e5c3778024b1\src\CodeInsight.Services\src\Paramete SL> rInfo\LookupSummaryTracker.cs:line SL> 118 SL> at SL> JetBrains.ReSharper.Psi.Impl.PsiManagerImpl.PsiManagerImpl.AsyncComm SL> itAllDocuments(CheckForInterrupt SL> checkForInterrupt, Action continuation, Action ifInterrupted) in SL> c:\Agent\work\2722e5c3778024b1\src\Psi\src\impl\PsiManager\PsiManage SL> rImpl.cs:line SL> 810 SL> at SL> JetBrains.ReSharper.CodeInsight.Services.ParameterInfo.LookupSummary SL> Tracker..ctor(ILookup SL> lookup, Boolean hideByEscape, ISolution solution) in SL> c:\Agent\work\2722e5c3778024b1\src\CodeInsight.Services\src\Paramete SL> rInfo\LookupSummaryTracker.cs:line SL> 63 SL> at SL> JetBrains.ReSharper.CodeInsight.Services.Lookup.Lookup.ShowLookup() SL> in SL> c:\Agent\work\2722e5c3778024b1\src\CodeInsight.Services\src\Lookup\L SL> ookup.cs:line SL> 168 SL> at SL> JetBrains.ReSharper.CodeInsight.Services.CSharp.CodeCompletion.CodeC SL> ompletionSession.ShowLookup(IList`1 SL> lookupItems, CodeCompletionType completionType) in SL> c:\Agent\work\2722e5c3778024b1\src\CodeInsight.Services.CSharp\src\C SL> odeCompletion\CodeCompletionSession.cs:line SL> 413 SL> at SL> JetBrains.ReSharper.CodeInsight.Services.CSharp.CodeCompletion.CodeC SL> ompletionSession.ShowList(IList`1 SL> list, Boolean autoComplete, CodeCompletionType completionType) in SL> c:\Agent\work\2722e5c3778024b1\src\CodeInsight.Services.CSharp\src\C SL> odeCompletion\CodeCompletionSession.cs:line SL> 349 SL> at SL> JetBrains.ReSharper.CodeInsight.Services.CSharp.CodeCompletion.CodeC SL> ompletionSession.AsyncCompletionExecutor.Finish() SL> in SL> c:\Agent\work\2722e5c3778024b1\src\CodeInsight.Services.CSharp\src\C SL> odeCompletion\CodeCompletionSession.cs:line SL> 232 SL> at SL> JetBrains.Application.InterruptableReadActivity.FinishingProc() SL> in SL> c:\Agent\work\2722e5c3778024b1\Platform\src\Shell\src\InterruptableR SL> eadActivity.cs:line SL> 193 SL> --- End of inner exception stack trace --- SL> at JetBrains.Application.InterruptableReadActivity.FinishingProc() SL> in SL> c:\Agent\work\2722e5c3778024b1\Platform\src\Shell\src\InterruptableR SL> eadActivity.cs:line SL> 198 column 5 SL> at JetBrains.Threading.ReentrancyGuard.Execute(String, Action) in SL> c:\Agent\work\2722e5c3778024b1\Platform\src\Util\src\Concurrency\Ree SL> ntrancyInvocator.cs:line SL> 190 column 6 SL> at SL> JetBrains.Threading.ReentrancyGuard.b__2(Queu SL> edAction) SL> in SL> c:\Agent\work\2722e5c3778024b1\Platform\src\Util\src\Concurrency\Ree SL> ntrancyInvocator.cs:line SL> 317 column 40 SL> at JetBrains.Threading.InterlockedQueue.TryDequeue(Action`1) in SL> c:\Agent\work\2722e5c3778024b1\Platform\src\Util\src\Concurrency\Ree SL> ntrancyInvocator.cs:line SL> 428 column 5 SL> at JetBrains.Threading.ReentrancyGuard.ExecutePendingActions() in SL> c:\Agent\work\2722e5c3778024b1\Platform\src\Util\src\Concurrency\Ree SL> ntrancyInvocator.cs:line SL> 320 column 3 SL> at JetBrains.Threading.Closure.Run() in SL> c:\Agent\work\2722e5c3778024b1\Platform\src\Util\src\Concurrency\Jet SL> Dispatcher.cs:line SL> 415 column 8 SL> at System.RuntimeMethodHandle._InvokeMethodFast(Object, Object[], SL> SignatureStruct&, MethodAttributes, RuntimeTypeHandle) SL> at System.RuntimeMethodHandle.InvokeMethodFast(Object, Object[], SL> Signature, MethodAttributes, RuntimeTypeHandle) SL> at System.Reflection.RuntimeMethodInfo.Invoke(Object, BindingFlags, SL> Binder, Object[], CultureInfo, Boolean) SL> at System.Delegate.DynamicInvokeImpl(Object[]) SL> at SL> System.Windows.Forms.Control.InvokeMarshaledCallbackDo(ThreadMethodE SL> ntry) SL> at SL> System.Windows.Forms.Control.InvokeMarshaledCallbackHelper(Object) SL> at System.Threading.ExecutionContext.runTryCode(Object) SL> at SL> System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaran SL> teedCleanup(TryCode, SL> CleanupCode, Object) SL> at System.Threading.ExecutionContext.RunInternal(ExecutionContext, SL> ContextCallback, Object) SL> at System.Threading.ExecutionContext.Run(ExecutionContext, SL> ContextCallback, Object) SL> at SL> System.Windows.Forms.Control.InvokeMarshaledCallback(ThreadMethodEnt SL> ry) SL> at System.Windows.Forms.Control.InvokeMarshaledCallbacks() SL> at System.Windows.Forms.Control.WndProc(Message&) SL> at System.Windows.Forms.ScrollableControl.WndProc(Message&) SL> at System.Windows.Forms.ContainerControl.WndProc(Message&) SL> at System.Windows.Forms.Form.WndProc(Message&) SL> at System.Windows.Forms.ControlNativeWindow.OnMessage(Message&) SL> at System.Windows.Forms.ControlNativeWindow.WndProc(Message&) SL> at System.Windows.Forms.NativeWindow.DebuggableCallback(IntPtr, SL> Int32, SL>]]> IntPtr, IntPtr)

Hi Ilya,

no problem. I only wanted to mention it here so that you can mark the
build as broken. Tomorrow on my presentation (see
http://www.afterlaunch.de) I will take build 772 which is more stable ;)

Regards,
Stefan Lieser
--
http://www.lieser-online.de


Ilya Ryzhenkov schrieb:

Hello Stefan,

We are doing major refactoring in the field of multithreading and
reentrancy policy (when message loop pumps messages in an unexpected
time, e.g. lock) and few nightly builds could be broken. Unfortunately,
this cannot be done in "atomic" manner, so that nightly builds remain
stable, sorry for inconvenience.

Sincerely,
Ilya Ryzhenkov

JetBrains, Inc
http://www.jetbrains.com
"Develop with pleasure!"


SL> Hi,
SL> SL> I just tried build 774, its unusable! I'm bombed with exceptions
SL> about reentrancy. Btw. the logs of the last builds have huge amounts
SL> of messages regarding reentrancy. Example from 774 below. Switching
SL> back to 772.
SL> SL> Regards,
SL> Stefan Lieser
SL> 12:42:57.493: Thread:1: EXCEPTION: The time interval must refer to a
SL> moment in the future.
SL> Parameter name: interval
SL> Actual value was 00:00:00.
SL> JetBrains.Util.LoggerException: The time interval must refer to a
SL> moment
SL> in the future.
SL> Parameter name: interval
SL> Actual value was 00:00:00. ---> System.ArgumentOutOfRangeException:
SL> The
SL> time interval must refer to a moment in the future.
SL> Parameter name: interval
SL> Actual value was 00:00:00.
SL> at JetBrains.Threading.ReentrancyAlarm.TimedAction..ctor(String
SL> name, Action action, TimeSpan interval, Recurrence recurrence,
SL> ReentrancyGuard reega) in
SL> c:\Agent\work\2722e5c3778024b1\Platform\src\Util\src\Concurrency\Ree
SL> ntrancyAlarm.cs:line
SL> 342
SL> at JetBrains.Threading.ReentrancyAlarm.QueueTimed(String name,
SL> Action action, TimeSpan interval, Recurrence recurrence) in
SL> c:\Agent\work\2722e5c3778024b1\Platform\src\Util\src\Concurrency\Ree
SL> ntrancyAlarm.cs:line
SL> 163
SL> at JetBrains.Threading.ReentrancyAlarm.QueueAt(String name,
SL> Action
SL> action, TimeSpan interval) in
SL> c:\Agent\work\2722e5c3778024b1\Platform\src\Util\src\Concurrency\Ree
SL> ntrancyAlarm.cs:line
SL> 130
SL> at JetBrains.Threading.Invocator.QueueAt(String name, Action
SL> action,
SL> TimeSpan interval) in
SL> c:\Agent\work\2722e5c3778024b1\Platform\src\Shell\src\Threading\Invo
SL> cator.cs:line
SL> 85
SL> at
SL> JetBrains.ReSharper.CodeInsight.Services.ParameterInfo.ParameterInfo
SL> PopupControllerImpl.PopupParameterInfo(ILookup
SL> lookup, ISolution solution) in
SL> c:\Agent\work\2722e5c3778024b1\src\CodeInsight.Services\src\Paramete
SL> rInfo\ParameterInfoPopupControllerImpl.cs:line
SL> 107
SL> at
SL> JetBrains.ReSharper.CodeInsight.Services.ParameterInfo.LookupSummary
SL> Tracker.ShowParameterInfo(ILookup
SL> lookup) in
SL> c:\Agent\work\2722e5c3778024b1\src\CodeInsight.Services\src\Paramete
SL> rInfo\LookupSummaryTracker.cs:line
SL> 132
SL> at
SL> JetBrains.ReSharper.CodeInsight.Services.ParameterInfo.LookupSummary
SL> Tracker.<ShowParameterInfo>b__0()
SL> in
SL> c:\Agent\work\2722e5c3778024b1\src\CodeInsight.Services\src\Paramete
SL> rInfo\LookupSummaryTracker.cs:line
SL> 118
SL> at
SL> JetBrains.ReSharper.Psi.Impl.PsiManagerImpl.PsiManagerImpl.AsyncComm
SL> itAllDocuments(CheckForInterrupt
SL> checkForInterrupt, Action continuation, Action ifInterrupted) in
SL> c:\Agent\work\2722e5c3778024b1\src\Psi\src\impl\PsiManager\PsiManage
SL> rImpl.cs:line
SL> 810
SL> at
SL> JetBrains.ReSharper.CodeInsight.Services.ParameterInfo.LookupSummary
SL> Tracker..ctor(ILookup
SL> lookup, Boolean hideByEscape, ISolution solution) in
SL> c:\Agent\work\2722e5c3778024b1\src\CodeInsight.Services\src\Paramete
SL> rInfo\LookupSummaryTracker.cs:line
SL> 63
SL> at
SL> JetBrains.ReSharper.CodeInsight.Services.Lookup.Lookup.ShowLookup()
SL> in
SL> c:\Agent\work\2722e5c3778024b1\src\CodeInsight.Services\src\Lookup\L
SL> ookup.cs:line
SL> 168
SL> at
SL> JetBrains.ReSharper.CodeInsight.Services.CSharp.CodeCompletion.CodeC
SL> ompletionSession.ShowLookup(IList`1
SL> lookupItems, CodeCompletionType completionType) in
SL> c:\Agent\work\2722e5c3778024b1\src\CodeInsight.Services.CSharp\src\C
SL> odeCompletion\CodeCompletionSession.cs:line
SL> 413
SL> at
SL> JetBrains.ReSharper.CodeInsight.Services.CSharp.CodeCompletion.CodeC
SL> ompletionSession.ShowList(IList`1
SL> list, Boolean autoComplete, CodeCompletionType completionType) in
SL> c:\Agent\work\2722e5c3778024b1\src\CodeInsight.Services.CSharp\src\C
SL> odeCompletion\CodeCompletionSession.cs:line
SL> 349
SL> at
SL> JetBrains.ReSharper.CodeInsight.Services.CSharp.CodeCompletion.CodeC
SL> ompletionSession.AsyncCompletionExecutor.Finish()
SL> in
SL> c:\Agent\work\2722e5c3778024b1\src\CodeInsight.Services.CSharp\src\C
SL> odeCompletion\CodeCompletionSession.cs:line
SL> 232
SL> at
SL> JetBrains.Application.InterruptableReadActivity.FinishingProc()
SL> in
SL> c:\Agent\work\2722e5c3778024b1\Platform\src\Shell\src\InterruptableR
SL> eadActivity.cs:line
SL> 193
SL> --- End of inner exception stack trace ---
SL> at JetBrains.Application.InterruptableReadActivity.FinishingProc()
SL> in
SL> c:\Agent\work\2722e5c3778024b1\Platform\src\Shell\src\InterruptableR
SL> eadActivity.cs:line
SL> 198 column 5
SL> at JetBrains.Threading.ReentrancyGuard.Execute(String, Action) in
SL> c:\Agent\work\2722e5c3778024b1\Platform\src\Util\src\Concurrency\Ree
SL> ntrancyInvocator.cs:line
SL> 190 column 6
SL> at
SL> JetBrains.Threading.ReentrancyGuard.<ExecutePendingActions>b__2(Queu
SL> edAction)
SL> in
SL> c:\Agent\work\2722e5c3778024b1\Platform\src\Util\src\Concurrency\Ree
SL> ntrancyInvocator.cs:line
SL> 317 column 40
SL> at JetBrains.Threading.InterlockedQueue.TryDequeue(Action`1) in
SL> c:\Agent\work\2722e5c3778024b1\Platform\src\Util\src\Concurrency\Ree
SL> ntrancyInvocator.cs:line
SL> 428 column 5
SL> at JetBrains.Threading.ReentrancyGuard.ExecutePendingActions() in
SL> c:\Agent\work\2722e5c3778024b1\Platform\src\Util\src\Concurrency\Ree
SL> ntrancyInvocator.cs:line
SL> 320 column 3
SL> at JetBrains.Threading.Closure.Run() in
SL> c:\Agent\work\2722e5c3778024b1\Platform\src\Util\src\Concurrency\Jet
SL> Dispatcher.cs:line
SL> 415 column 8
SL> at System.RuntimeMethodHandle._InvokeMethodFast(Object, Object[],
SL> SignatureStruct&, MethodAttributes, RuntimeTypeHandle)
SL> at System.RuntimeMethodHandle.InvokeMethodFast(Object, Object[],
SL> Signature, MethodAttributes, RuntimeTypeHandle)
SL> at System.Reflection.RuntimeMethodInfo.Invoke(Object, BindingFlags,
SL> Binder, Object[], CultureInfo, Boolean)
SL> at System.Delegate.DynamicInvokeImpl(Object[])
SL> at
SL> System.Windows.Forms.Control.InvokeMarshaledCallbackDo(ThreadMethodE
SL> ntry)
SL> at
SL> System.Windows.Forms.Control.InvokeMarshaledCallbackHelper(Object)
SL> at System.Threading.ExecutionContext.runTryCode(Object)
SL> at
SL> System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaran
SL> teedCleanup(TryCode,
SL> CleanupCode, Object)
SL> at System.Threading.ExecutionContext.RunInternal(ExecutionContext,
SL> ContextCallback, Object)
SL> at System.Threading.ExecutionContext.Run(ExecutionContext,
SL> ContextCallback, Object)
SL> at
SL> System.Windows.Forms.Control.InvokeMarshaledCallback(ThreadMethodEnt
SL> ry)
SL> at System.Windows.Forms.Control.InvokeMarshaledCallbacks()
SL> at System.Windows.Forms.Control.WndProc(Message&)
SL> at System.Windows.Forms.ScrollableControl.WndProc(Message&)
SL> at System.Windows.Forms.ContainerControl.WndProc(Message&)
SL> at System.Windows.Forms.Form.WndProc(Message&)
SL> at System.Windows.Forms.ControlNativeWindow.OnMessage(Message&)
SL> at System.Windows.Forms.ControlNativeWindow.WndProc(Message&)
SL> at System.Windows.Forms.NativeWindow.DebuggableCallback(IntPtr,
SL> Int32,
SL> IntPtr, IntPtr)

Hello Ilya,

But it has a problem, the EAP license will be expired in 3 days. Can we expect a more stable version in 3 days? Or can we expand the license expiration?

Thanks,

t800t8

Hello t800t8,

I hope we will fix most annoying problems within few days. Some of the were
already fixed, so may be even next nightly will be usable.

Sincerely,
Ilya Ryzhenkov

JetBrains, Inc
http://www.jetbrains.com
"Develop with pleasure!"


t> Hello Ilya,
t>
t> But it has a problem, the EAP license will be expired in 3 days. Can
t> we expect a more stable version in 3 days? Or can we expand the
t> license expiration?
t>
t> Thanks,
t>
t> t800t8
t>

"Ilya Ryzhenkov" <orangy@jetbrains.com> wrote in message
news:76a2bd0b154f558ca6962919599e0@news.intellij.net...

Hello t800t8,

>

I hope we will fix most annoying problems within few days. Some of the
were already fixed, so may be even next nightly will be usable.

Ah but it's the MVP summit next weekend; so a stable, non expired build for
that week when some of us are doing a hackathon or two would be useful!