Navigate To Overriding Members?

A couple of issues:

I have a source file with lots of "redundant qualifiers" in it. It also
overrides some base class methods. This means there is a mix of blue and
yellow/orange lines in the error bar on the right.

1) Why are overridden members highlighted in blue on the right? I really
don't like this. I only want errors and warnings over there. Is there some
way to turn this off?

When I go to the first redundant qualifier by clicking on the first
yellow/orange mark in the right-side error bar (which happens to be the
top-most highlight, since the redundant qualifier is on the class definition
specifying the completely qualified type name of the type being inhereted
from), I don't get a yellow lightbulb on the line. Instead I get a yellow
light-bulb up in the upper left corner of the editor (over the gutter) with
the only option being "Navigate to overridden member".

2) My cursor is on a warning, not on an overridden member...it's an error to
show the lightbulb up in the corner. In particular, I cannot access the
quick-fix for this line of code through the UI. Even Alt-Enter brings up
the wrong lightbulb.

3) I never want to see this "Navigate to overriding members" lightbulb in
the first place. What is it there for? It serves no purpose that I can
tell, and seems completely redundant. Can this be removed? In addition to
it popping up in error here, I can't imagine when I'd ever want it to pop-up
at all. It's not a quick fix. It doesn't belong in a lightbulb.

I also note that clicking on "redundant qualifier" highlights in the right
error bar that are BELOW the first blue "overridden member" bar, works fine.
It's only the ones above that that seem to be at issue.

I still hate having to manually remove each redundant qualifier one by one.
It's very annoying. I do NOT want to "reformat" my entire source file
(people I share the file with would be upset, and mixing formatting changes
with code changes in a single check-in is a no-no at my company).

4) Can you PLEASE add a "Remove all redundant qualifiers like this one" as
an option under the lighbulb?? PLEASE? Even a blanket "Remove All
Redundant Qualifiers In This File" would be nice, though the "like this one"
would be nicer (i.e., remove all the unnecessary qualifications of this
class only, not all "this." qualifiers, etc).



4 comments
Comment actions Permalink

1) Why are overridden members highlighted in blue on the right? I
really don't like this. I only want errors and warnings over there.
Is there some way to turn this off?


I cannot see any highlighting on the right gutter corresponding to the overriden
members. Are you sure? Could you post a screenshot?


When I go to the first redundant qualifier by clicking on the first
yellow/orange mark in the right-side error bar (which happens to be
the top-most highlight, since the redundant qualifier is on the class
definition specifying the completely qualified type name of the type
being inhereted from), I don't get a yellow lightbulb on the line.
Instead I get a yellow light-bulb up in the upper left corner of the
editor (over the gutter) with the only option being "Navigate to
overridden member".

2) My cursor is on a warning, not on an overridden member...it's an
error to show the lightbulb up in the corner. In particular, I cannot
access the quick-fix for this line of code through the UI. Even
Alt-Enter brings up the wrong lightbulb.


Do you have collapsed regions in the editor? It's a known bug that the bulb
is positioned incorrectly in this case. Will be fixed for the release.


3) I never want to see this "Navigate to overriding members" lightbulb
in the first place. What is it there for? It serves no purpose that
I can tell, and seems completely redundant. Can this be removed? In
addition to it popping up in error here, I can't imagine when I'd ever
want it to pop-up at all. It's not a quick fix. It doesn't belong in
a lightbulb.


"Navigate to overriding members" should be shown only for references in the
list of bases of a class. It's a 'context action' for easy navigation to
declarations of members from the base that are overriden by the current class.

I still hate having to manually remove each redundant qualifier one by
one. It's very annoying. I do NOT want to "reformat" my entire source
file (people I share the file with would be upset, and mixing
formatting changes with code changes in a single check-in is a no-no
at my company).

4) Can you PLEASE add a "Remove all redundant qualifiers like this
one" as an option under the lighbulb?? PLEASE? Even a blanket
"Remove All Redundant Qualifiers In This File" would be nice, though
the "like this one" would be nicer (i.e., remove all the unnecessary
qualifications of this class only, not all "this." qualifiers, etc).


Did you try "Optimize Usings" action? It does not affect formatting so there
will be not too much changes in the code.

Valentin Kipiatkov
Chief Scientist, Vice President of Product Development
JetBrains, Inc
http://www.jetbrains.com
"Develop with pleasure!"

A couple of issues:

I have a source file with lots of "redundant qualifiers" in it. It
also overrides some base class methods. This means there is a mix of
blue and yellow/orange lines in the error bar on the right.

1) Why are overridden members highlighted in blue on the right? I
really don't like this. I only want errors and warnings over there.
Is there some way to turn this off?

When I go to the first redundant qualifier by clicking on the first
yellow/orange mark in the right-side error bar (which happens to be
the top-most highlight, since the redundant qualifier is on the class
definition specifying the completely qualified type name of the type
being inhereted from), I don't get a yellow lightbulb on the line.
Instead I get a yellow light-bulb up in the upper left corner of the
editor (over the gutter) with the only option being "Navigate to
overridden member".

2) My cursor is on a warning, not on an overridden member...it's an
error to show the lightbulb up in the corner. In particular, I cannot
access the quick-fix for this line of code through the UI. Even
Alt-Enter brings up the wrong lightbulb.

3) I never want to see this "Navigate to overriding members" lightbulb
in the first place. What is it there for? It serves no purpose that
I can tell, and seems completely redundant. Can this be removed? In
addition to it popping up in error here, I can't imagine when I'd ever
want it to pop-up at all. It's not a quick fix. It doesn't belong in
a lightbulb.

I also note that clicking on "redundant qualifier" highlights in the
right error bar that are BELOW the first blue "overridden member" bar,
works fine. It's only the ones above that that seem to be at issue.

I still hate having to manually remove each redundant qualifier one by
one. It's very annoying. I do NOT want to "reformat" my entire source
file (people I share the file with would be upset, and mixing
formatting changes with code changes in a single check-in is a no-no
at my company).

4) Can you PLEASE add a "Remove all redundant qualifiers like this
one" as an option under the lighbulb?? PLEASE? Even a blanket
"Remove All Redundant Qualifiers In This File" would be nice, though
the "like this one" would be nicer (i.e., remove all the unnecessary
qualifications of this class only, not all "this." qualifiers, etc).



0
Comment actions Permalink

Very odd. I cannot reproduce it today (to get a screen shot) but it was
most definitely there yesterday. Bright blue tick marks in the right error
bar for all the overridden methods. I swear I'm not on drugs.

And I made sure to expand the collapsed regions and I was still seeing the
problem. It seemed to be completely tied to the fact that there were blue
bars in the error margin, and affected any legitimate warning above the
first blue bar. I duplicated it several times yesterday before reporting
it. Today, I see no sign of the issue at all (other than the known issue
with collapsed regions).

But it definitely seemed like something got messed up, as that "Navigate to
overridden members" quickfix was happening on every legitimate warning above
the first blue bar. SOMETHING got messed up, which is now apparently okay.
If I see it again, I'll report with more detail.

But I did notice today that doing a bunch of the redundant-qualifier fixes
(still one at a time, I can't find any other way to remove them ... optimize
usings doesn't remove redundant qualifiers even when I have the 'shorten
qualified references' checkbox checked), that at some point during the
manual and laborious fixing of about a dozen of these issues, the lightbulb
just stopped popping up. Alt-Enter didn't work either. I had to manually
position the cursor and delete the redundant qualifiers. It happened only
for this file. I could go to another file and use the quick fixes all I
wanted, but coming back to this one, and there was simply no lightbulbs for
the warnings. I didn't try closing and reopening the file, I just fixed
things manually. But I thought you should be aware of that. It seems some
things are still a bit flakey here...

But my desire to have an option to "remove all redundant qualifiers like
this one" and/or "remove all redundant qualifiers" as a quickfix option
still stands :)

"Valentin Kipiatkov (JetBrains)" <valentin@jetbrains.com> wrote in message
news:3fdb29a6a6fb88c80139d2cbff42@news.intellij.net...
>> 1) Why are overridden members highlighted in blue on the right? I
>> really don't like this. I only want errors and warnings over there.
>> Is there some way to turn this off?
>

I cannot see any highlighting on the right gutter corresponding to the
overriden members. Are you sure? Could you post a screenshot?

>
>>
>> When I go to the first redundant qualifier by clicking on the first
>> yellow/orange mark in the right-side error bar (which happens to be
>> the top-most highlight, since the redundant qualifier is on the class
>> definition specifying the completely qualified type name of the type
>> being inhereted from), I don't get a yellow lightbulb on the line.
>> Instead I get a yellow light-bulb up in the upper left corner of the
>> editor (over the gutter) with the only option being "Navigate to
>> overridden member".
>>
>> 2) My cursor is on a warning, not on an overridden member...it's an
>> error to show the lightbulb up in the corner. In particular, I cannot
>> access the quick-fix for this line of code through the UI. Even
>> Alt-Enter brings up the wrong lightbulb.
>

Do you have collapsed regions in the editor? It's a known bug that the
bulb is positioned incorrectly in this case. Will be fixed for the
release.

>
>>
>> 3) I never want to see this "Navigate to overriding members" lightbulb
>> in the first place. What is it there for? It serves no purpose that
>> I can tell, and seems completely redundant. Can this be removed? In
>> addition to it popping up in error here, I can't imagine when I'd ever
>> want it to pop-up at all. It's not a quick fix. It doesn't belong in
>> a lightbulb.
>

"Navigate to overriding members" should be shown only for references in
the list of bases of a class. It's a 'context action' for easy navigation
to declarations of members from the base that are overriden by the current
class.

>
>> I still hate having to manually remove each redundant qualifier one by
>> one. It's very annoying. I do NOT want to "reformat" my entire source
>> file (people I share the file with would be upset, and mixing
>> formatting changes with code changes in a single check-in is a no-no
>> at my company).
>>
>> 4) Can you PLEASE add a "Remove all redundant qualifiers like this
>> one" as an option under the lighbulb?? PLEASE? Even a blanket
>> "Remove All Redundant Qualifiers In This File" would be nice, though
>> the "like this one" would be nicer (i.e., remove all the unnecessary
>> qualifications of this class only, not all "this." qualifiers, etc).
>

Did you try "Optimize Usings" action? It does not affect formatting so
there will be not too much changes in the code.

>

Valentin Kipiatkov
Chief Scientist, Vice President of Product Development
JetBrains, Inc
http://www.jetbrains.com
"Develop with pleasure!"

>
>> A couple of issues:
>>
>> I have a source file with lots of "redundant qualifiers" in it. It
>> also overrides some base class methods. This means there is a mix of
>> blue and yellow/orange lines in the error bar on the right.
>>
>> 1) Why are overridden members highlighted in blue on the right? I
>> really don't like this. I only want errors and warnings over there.
>> Is there some way to turn this off?
>>
>> When I go to the first redundant qualifier by clicking on the first
>> yellow/orange mark in the right-side error bar (which happens to be
>> the top-most highlight, since the redundant qualifier is on the class
>> definition specifying the completely qualified type name of the type
>> being inhereted from), I don't get a yellow lightbulb on the line.
>> Instead I get a yellow light-bulb up in the upper left corner of the
>> editor (over the gutter) with the only option being "Navigate to
>> overridden member".
>>
>> 2) My cursor is on a warning, not on an overridden member...it's an
>> error to show the lightbulb up in the corner. In particular, I cannot
>> access the quick-fix for this line of code through the UI. Even
>> Alt-Enter brings up the wrong lightbulb.
>>
>> 3) I never want to see this "Navigate to overriding members" lightbulb
>> in the first place. What is it there for? It serves no purpose that
>> I can tell, and seems completely redundant. Can this be removed? In
>> addition to it popping up in error here, I can't imagine when I'd ever
>> want it to pop-up at all. It's not a quick fix. It doesn't belong in
>> a lightbulb.
>>
>> I also note that clicking on "redundant qualifier" highlights in the
>> right error bar that are BELOW the first blue "overridden member" bar,
>> works fine. It's only the ones above that that seem to be at issue.
>>
>> I still hate having to manually remove each redundant qualifier one by
>> one. It's very annoying. I do NOT want to "reformat" my entire source
>> file (people I share the file with would be upset, and mixing
>> formatting changes with code changes in a single check-in is a no-no
>> at my company).
>>
>> 4) Can you PLEASE add a "Remove all redundant qualifiers like this
>> one" as an option under the lighbulb?? PLEASE? Even a blanket
>> "Remove All Redundant Qualifiers In This File" would be nice, though
>> the "like this one" would be nicer (i.e., remove all the unnecessary
>> qualifications of this class only, not all "this." qualifiers, etc).
>>
>



0
Comment actions Permalink

I replicated the "disappearing lightbulb" problem --- where it sometimes
just fails to appear for some reason --- and it does seem to be connected to
collapsed regions, so it seems to be a problem you're already aware of.
When I did a ML to expand all, the lightbulb came right back.

Just FYI.


"Valentin Kipiatkov (JetBrains)" <valentin@jetbrains.com> wrote in message
news:3fdb29a6a6fb88c80139d2cbff42@news.intellij.net...
>> 1) Why are overridden members highlighted in blue on the right? I
>> really don't like this. I only want errors and warnings over there.
>> Is there some way to turn this off?
>

I cannot see any highlighting on the right gutter corresponding to the
overriden members. Are you sure? Could you post a screenshot?

>
>>
>> When I go to the first redundant qualifier by clicking on the first
>> yellow/orange mark in the right-side error bar (which happens to be
>> the top-most highlight, since the redundant qualifier is on the class
>> definition specifying the completely qualified type name of the type
>> being inhereted from), I don't get a yellow lightbulb on the line.
>> Instead I get a yellow light-bulb up in the upper left corner of the
>> editor (over the gutter) with the only option being "Navigate to
>> overridden member".
>>
>> 2) My cursor is on a warning, not on an overridden member...it's an
>> error to show the lightbulb up in the corner. In particular, I cannot
>> access the quick-fix for this line of code through the UI. Even
>> Alt-Enter brings up the wrong lightbulb.
>

Do you have collapsed regions in the editor? It's a known bug that the
bulb is positioned incorrectly in this case. Will be fixed for the
release.

>
>>
>> 3) I never want to see this "Navigate to overriding members" lightbulb
>> in the first place. What is it there for? It serves no purpose that
>> I can tell, and seems completely redundant. Can this be removed? In
>> addition to it popping up in error here, I can't imagine when I'd ever
>> want it to pop-up at all. It's not a quick fix. It doesn't belong in
>> a lightbulb.
>

"Navigate to overriding members" should be shown only for references in
the list of bases of a class. It's a 'context action' for easy navigation
to declarations of members from the base that are overriden by the current
class.

>
>> I still hate having to manually remove each redundant qualifier one by
>> one. It's very annoying. I do NOT want to "reformat" my entire source
>> file (people I share the file with would be upset, and mixing
>> formatting changes with code changes in a single check-in is a no-no
>> at my company).
>>
>> 4) Can you PLEASE add a "Remove all redundant qualifiers like this
>> one" as an option under the lighbulb?? PLEASE? Even a blanket
>> "Remove All Redundant Qualifiers In This File" would be nice, though
>> the "like this one" would be nicer (i.e., remove all the unnecessary
>> qualifications of this class only, not all "this." qualifiers, etc).
>

Did you try "Optimize Usings" action? It does not affect formatting so
there will be not too much changes in the code.

>

Valentin Kipiatkov
Chief Scientist, Vice President of Product Development
JetBrains, Inc
http://www.jetbrains.com
"Develop with pleasure!"

>
>> A couple of issues:
>>
>> I have a source file with lots of "redundant qualifiers" in it. It
>> also overrides some base class methods. This means there is a mix of
>> blue and yellow/orange lines in the error bar on the right.
>>
>> 1) Why are overridden members highlighted in blue on the right? I
>> really don't like this. I only want errors and warnings over there.
>> Is there some way to turn this off?
>>
>> When I go to the first redundant qualifier by clicking on the first
>> yellow/orange mark in the right-side error bar (which happens to be
>> the top-most highlight, since the redundant qualifier is on the class
>> definition specifying the completely qualified type name of the type
>> being inhereted from), I don't get a yellow lightbulb on the line.
>> Instead I get a yellow light-bulb up in the upper left corner of the
>> editor (over the gutter) with the only option being "Navigate to
>> overridden member".
>>
>> 2) My cursor is on a warning, not on an overridden member...it's an
>> error to show the lightbulb up in the corner. In particular, I cannot
>> access the quick-fix for this line of code through the UI. Even
>> Alt-Enter brings up the wrong lightbulb.
>>
>> 3) I never want to see this "Navigate to overriding members" lightbulb
>> in the first place. What is it there for? It serves no purpose that
>> I can tell, and seems completely redundant. Can this be removed? In
>> addition to it popping up in error here, I can't imagine when I'd ever
>> want it to pop-up at all. It's not a quick fix. It doesn't belong in
>> a lightbulb.
>>
>> I also note that clicking on "redundant qualifier" highlights in the
>> right error bar that are BELOW the first blue "overridden member" bar,
>> works fine. It's only the ones above that that seem to be at issue.
>>
>> I still hate having to manually remove each redundant qualifier one by
>> one. It's very annoying. I do NOT want to "reformat" my entire source
>> file (people I share the file with would be upset, and mixing
>> formatting changes with code changes in a single check-in is a no-no
>> at my company).
>>
>> 4) Can you PLEASE add a "Remove all redundant qualifiers like this
>> one" as an option under the lighbulb?? PLEASE? Even a blanket
>> "Remove All Redundant Qualifiers In This File" would be nice, though
>> the "like this one" would be nicer (i.e., remove all the unnecessary
>> qualifications of this class only, not all "this." qualifiers, etc).
>>
>



0
Comment actions Permalink

The interfere between lightbulb and collapsed regions is a well-known
problem :(
It definetelyshould have been fixed by release

--
Eugene Pasynkov
Developer
JetBrains, Inc
http://www.jetbrains.com
"Develop with pleasure!"
"Paul Bradshaw" <pbradshaw@advsol.com> wrote in message
news:dt2kea$5mr$1@is.intellij.net...
>I replicated the "disappearing lightbulb" problem --- where it sometimes
>just fails to appear for some reason --- and it does seem to be connected
>to collapsed regions, so it seems to be a problem you're already aware of.
>When I did a ML to expand all, the lightbulb came right back.
>

Just FYI.

>
>

"Valentin Kipiatkov (JetBrains)" <valentin@jetbrains.com> wrote in message
news:3fdb29a6a6fb88c80139d2cbff42@news.intellij.net...

>>> 1) Why are overridden members highlighted in blue on the right? I
>>> really don't like this. I only want errors and warnings over there.
>>> Is there some way to turn this off?
>>
>> I cannot see any highlighting on the right gutter corresponding to the
>> overriden members. Are you sure? Could you post a screenshot?
>>
>>>
>>> When I go to the first redundant qualifier by clicking on the first
>>> yellow/orange mark in the right-side error bar (which happens to be
>>> the top-most highlight, since the redundant qualifier is on the class
>>> definition specifying the completely qualified type name of the type
>>> being inhereted from), I don't get a yellow lightbulb on the line.
>>> Instead I get a yellow light-bulb up in the upper left corner of the
>>> editor (over the gutter) with the only option being "Navigate to
>>> overridden member".
>>>
>>> 2) My cursor is on a warning, not on an overridden member...it's an
>>> error to show the lightbulb up in the corner. In particular, I cannot
>>> access the quick-fix for this line of code through the UI. Even
>>> Alt-Enter brings up the wrong lightbulb.
>>
>> Do you have collapsed regions in the editor? It's a known bug that the
>> bulb is positioned incorrectly in this case. Will be fixed for the
>> release.
>>
>>>
>>> 3) I never want to see this "Navigate to overriding members" lightbulb
>>> in the first place. What is it there for? It serves no purpose that
>>> I can tell, and seems completely redundant. Can this be removed? In
>>> addition to it popping up in error here, I can't imagine when I'd ever
>>> want it to pop-up at all. It's not a quick fix. It doesn't belong in
>>> a lightbulb.
>>
>> "Navigate to overriding members" should be shown only for references in
>> the list of bases of a class. It's a 'context action' for easy navigation
>> to declarations of members from the base that are overriden by the
>> current class.
>>
>>> I still hate having to manually remove each redundant qualifier one by
>>> one. It's very annoying. I do NOT want to "reformat" my entire source
>>> file (people I share the file with would be upset, and mixing
>>> formatting changes with code changes in a single check-in is a no-no
>>> at my company).
>>>
>>> 4) Can you PLEASE add a "Remove all redundant qualifiers like this
>>> one" as an option under the lighbulb?? PLEASE? Even a blanket
>>> "Remove All Redundant Qualifiers In This File" would be nice, though
>>> the "like this one" would be nicer (i.e., remove all the unnecessary
>>> qualifications of this class only, not all "this." qualifiers, etc).
>>
>> Did you try "Optimize Usings" action? It does not affect formatting so
>> there will be not too much changes in the code.
>>
>> Valentin Kipiatkov
>> Chief Scientist, Vice President of Product Development
>> JetBrains, Inc
>> http://www.jetbrains.com
>> "Develop with pleasure!"
>>
>>> A couple of issues:
>>>
>>> I have a source file with lots of "redundant qualifiers" in it. It
>>> also overrides some base class methods. This means there is a mix of
>>> blue and yellow/orange lines in the error bar on the right.
>>>
>>> 1) Why are overridden members highlighted in blue on the right? I
>>> really don't like this. I only want errors and warnings over there.
>>> Is there some way to turn this off?
>>>
>>> When I go to the first redundant qualifier by clicking on the first
>>> yellow/orange mark in the right-side error bar (which happens to be
>>> the top-most highlight, since the redundant qualifier is on the class
>>> definition specifying the completely qualified type name of the type
>>> being inhereted from), I don't get a yellow lightbulb on the line.
>>> Instead I get a yellow light-bulb up in the upper left corner of the
>>> editor (over the gutter) with the only option being "Navigate to
>>> overridden member".
>>>
>>> 2) My cursor is on a warning, not on an overridden member...it's an
>>> error to show the lightbulb up in the corner. In particular, I cannot
>>> access the quick-fix for this line of code through the UI. Even
>>> Alt-Enter brings up the wrong lightbulb.
>>>
>>> 3) I never want to see this "Navigate to overriding members" lightbulb
>>> in the first place. What is it there for? It serves no purpose that
>>> I can tell, and seems completely redundant. Can this be removed? In
>>> addition to it popping up in error here, I can't imagine when I'd ever
>>> want it to pop-up at all. It's not a quick fix. It doesn't belong in
>>> a lightbulb.
>>>
>>> I also note that clicking on "redundant qualifier" highlights in the
>>> right error bar that are BELOW the first blue "overridden member" bar,
>>> works fine. It's only the ones above that that seem to be at issue.
>>>
>>> I still hate having to manually remove each redundant qualifier one by
>>> one. It's very annoying. I do NOT want to "reformat" my entire source
>>> file (people I share the file with would be upset, and mixing
>>> formatting changes with code changes in a single check-in is a no-no
>>> at my company).
>>>
>>> 4) Can you PLEASE add a "Remove all redundant qualifiers like this
>>> one" as an option under the lighbulb?? PLEASE? Even a blanket
>>> "Remove All Redundant Qualifiers In This File" would be nice, though
>>> the "like this one" would be nicer (i.e., remove all the unnecessary
>>> qualifications of this class only, not all "this." qualifiers, etc).
>>>
>>
>>
>



0

Please sign in to leave a comment.