Safe Delete isn't that safe with types (R# 3 build 508)

Hi Guys,

I'm clearing a load of deadwood from a system at the moment, using safe delete.

So, there are a load of classes that need deleting, and I went to do this with resharper as I can't be bothered to find them in the solution explorer (solution tracking) doesn't always work. It seems to work by deleting the file, but, the issue is it doesn't delete it fro the source repository, but rather sets it as edited. Checking in then goes horribly wrong.

Am I doing something silly here?

Chrs

P.

8 comments
Comment actions Permalink

Hello Paul,

do I understand correctly that when Safe Delete deletes a file, it is incorrectly
deleted from the version control? What version
control system you're using? Thanks.

Dmitry Shaporenkov
JetBrains, Inc
http://www.jetbrains.com
"Develop with pleasure!"


Hi Guys,

I'm clearing a load of deadwood from a system at the moment, using
safe delete.

So, there are a load of classes that need deleting, and I went to do
this with resharper as I can't be bothered to find them in the
solution explorer (solution tracking) doesn't always work. It seems
to work by deleting the file, but, the issue is it doesn't delete it
fro the source repository, but rather sets it as edited. Checking in
then goes horribly wrong.

Am I doing something silly here?

Chrs

P.



0
Comment actions Permalink

Hi Dmitry,

Thanks so much for the quick reply!

Sorry, I should have said. It's TFS.

Chrs

P.

0
Comment actions Permalink

Hello Paul,

I've created a request for this problem: http://www.jetbrains.net/jira/browse/RSRP-46770

Thanks for reporting it!


Dmitry Shaporenkov
JetBrains, Inc
http://www.jetbrains.com
"Develop with pleasure!"


Hi Dmitry,

Thanks so much for the quick reply!

Sorry, I should have said. It's TFS.

Chrs

P.



0
Comment actions Permalink

Thats's great.

The work around for now is to use safe delete for member deletion, but for type deletion, which ends in the file being deleted, it's best to delete from the solution explorer.

Chrs

P.

0
Comment actions Permalink

Hmm, as far as I remember Safe Delete used to ask the user whether the file
needs to be deleted (so you
could just reply 'No' and avoid the problem). However, it seems that this
behavior was lost in 3.0. I've submitted
a request to restore it: http://www.jetbrains.net/jira/browse/RSRP-46791


Dmitry Shaporenkov
JetBrains, Inc
http://www.jetbrains.com
"Develop with pleasure!"


Thats's great.

The work around for now is to use safe delete for member deletion, but
for type deletion, which ends in the file being deleted, it's best to
delete from the solution explorer.

Chrs

P.



0
Comment actions Permalink

y, that would be great, as deletion is a nasty breaking change when not planned for.

I have another question on deletion. A colleague of mine has been using safe delete also. I'm not certain, but, does resharper check for asp.net inline c# calls? Like I said, not certain, but if he was using safe delete, then it missed some inline asp.net declarative calls in the binding code. Sadly the guy checked in on Friday, didn't realise that the asp.net is throwing errors that it can't find a method name, and is off ill today! :(

Chrs for your help in advance

Paul

0
Comment actions Permalink

I can confirm that the current official release of resharper does not highlight usages of methods when used as part of an object binding expression.

It might be worth raising this as a defect if it isn't already.

Chrs
P.

0
Comment actions Permalink

Hello Paul,

could you please submit it to our bug tracker along with a sample of code
illustrating such expressions? Thanks.


Dmitry Shaporenkov
JetBrains, Inc
http://www.jetbrains.com
"Develop with pleasure!"


I can confirm that the current official release of resharper does not
highlight usages of methods when used as part of an object binding
expression.

It might be worth raising this as a defect if it isn't already.

Chrs
P.



0

Please sign in to leave a comment.