I am new to ReSharper and I have noticed it says a lot of our bool tests for null are always true or false when in fact they are not. I thought that odd, because we usually test for this, and only put them in when we know for a fact an object can be null or we had a NullReferenceException at some point and added to fix a bug.
So I dug into several of them, and sure enough every single one of suggestion by ReSharper is wrong here. I can look at the code and follow it through and see where it can be set to null, and that nulls are being set intentionally as a way to check for something.
I understand how it can set for this within its current immediate scope, however once you start calling other methods how can it be figuring out if a method that is being called will never return a null object and therefor make the check unneeded? This is really annoying that it sees this at just about every null check in our code, and before I disable it I want to know what is up.